[아크] 코틀린 자동차 경주 제출합니다. #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laco-dev
requested changes
Feb 9, 2023
| import org.assertj.core.api.Assertions.assertThat | ||
| import org.junit.jupiter.api.Test | ||
|
|
||
| internal class CarTest { |
There was a problem hiding this comment.
하나의 기능은 구현 코드와 테스트 코드가 세트라고 생각해주시면 됩니다!
There was a problem hiding this comment.
구현 코드와 테스트 코드를 각자 커밋 하지말고 한번에 커밋하라는 말씀으로 이해 했는데 맞을까요??
There was a problem hiding this comment.
네, 맞습니다.
만약 해당 기능이 불필요하거나 잘못되어서 롤백을 하는 등의 상황이 오면, 하나 이상의 작업을 되돌려야 하고,
테스트 없는 기능은 반대로 기능 없는 테스트는 완성되지 않은 상태입니다.
laco-dev
approved these changes
Feb 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
많은 경험을 할 수 있었습니다!