Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[아크] 1, 2단계 영화 극장 선택 제출합니다. #8

Merged
merged 38 commits into from
Apr 28, 2023

Conversation

re4rk
Copy link

@re4rk re4rk commented Apr 27, 2023

안녕하세요!! 리뷰어님!!
이번 미션동안 잘 부탁드립니다!!

Copy link

@galcyurio galcyurio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전체적으로 코드 가독성이 아주 좋았습니다 💯
피드백을 남겨두었으니 반영 후 다시 요청해주세요.

Copy link

@galcyurio galcyurio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

의도대로 피드백 잘 반영해주셨네요 👍
역할별로 객체로 분리하거나 확장함수로 잘 분리해주셔서 가독성이 좋았습니다.
반영되지 않은 피드백이 있는데 확인 후 다음 단계에 반영해주세요!

const val CHANNEL_NAME = "movie_channel_name"
const val CHANNEL_DESCRIPTION = "This is a movie channel"

val atomicNotifyId = AtomicInteger(0x001)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코멘트 확인해주세요~

@galcyurio galcyurio merged commit 8043296 into woowacourse:re4rk Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants