-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[아크] 1, 2단계 영화 극장 선택 제출합니다. #8
Conversation
- reservation과 ticket이 혼용되는 것을 방지하기 위해 변경
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
전체적으로 코드 가독성이 아주 좋았습니다 💯
피드백을 남겨두었으니 반영 후 다시 요청해주세요.
app/src/main/java/woowacourse/movie/ui/fragment/setting/SettingFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/woowacourse/movie/ui/confirm/AlarmReceiver.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/woowacourse/movie/ui/confirm/ReservationConfirmActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/woowacourse/movie/ui/confirm/ReservationConfirmActivity.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
의도대로 피드백 잘 반영해주셨네요 👍
역할별로 객체로 분리하거나 확장함수로 잘 분리해주셔서 가독성이 좋았습니다.
반영되지 않은 피드백이 있는데 확인 후 다음 단계에 반영해주세요!
const val CHANNEL_NAME = "movie_channel_name" | ||
const val CHANNEL_DESCRIPTION = "This is a movie channel" | ||
|
||
val atomicNotifyId = AtomicInteger(0x001) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코멘트 확인해주세요~
안녕하세요!! 리뷰어님!!
이번 미션동안 잘 부탁드립니다!!