Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter return type #3

Closed
jpasquers opened this issue Feb 9, 2022 · 1 comment · Fixed by #4
Closed

Filter return type #3

jpasquers opened this issue Feb 9, 2022 · 1 comment · Fixed by #4

Comments

@jpasquers
Copy link
Contributor

Hey, I noticed that the return type defined here:

bcp-47-match/index.js

Line 24 in 94c31cb

* @returns {Tag}

Is a single string for the filter type methods, but the readme and code suggest the actual return type is an Array aka Tags. Is there a piece I'm missing here? I'm glad to make a PR if you think it should be changed
@wooorm
Copy link
Owner

wooorm commented Feb 9, 2022

Been a while that I looked into this code, but seems you’re right that it should be Tags indeed! PR welcome!

@jpasquers jpasquers mentioned this issue Feb 9, 2022
Merged
@wooorm wooorm closed this as completed in #4 Mar 30, 2022
wooorm pushed a commit that referenced this issue Mar 30, 2022
@jpasquers
Fix return type of filter
392cd02 
Closes GH-3.
Closes GH-4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix return type of filter jpasquers/bcp-47-match
2 participants
@wooorm @jpasquers