fix HTML search in Django >= 1.8 #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lioscro
changed the title
|
Thanks for catching this -- you can actually just do the fix for the latest django, this is our current support of the next release: 'Django>=3,<4 ;python_version>="3.7"', If its possible a unit test would be great to catch this in the future, but no worries if that is a tall ask as its already not covered. |
|
Tests are in. Think I'll leave the version check for now since it can't hurt. |
Chris7
reviewed
Aug 12, 2022
| self.json_view_func = wooey_views.WooeyScriptSearchJSON.as_view() | ||
| self.json_html_view_func = wooey_views.WooeyScriptSearchJSONHTML.as_view() | ||
| # the test server doesn't have celery running | ||
| settings.WOOEY_CELERY = False |
There was a problem hiding this comment.
this should be put in test_settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
context_instancekwarg torender_to_stringhas been deprecated since Django 1.8. Added a check for the Django version to call the function with correct arguments.