fix notification of connection change on check connection

woodser · Jan 8, 2025 · 1e31649 · 1e31649
1 parent 950c3ed
commit 1e31649
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/main/java/monero/common/MoneroConnectionManager.java b/src/main/java/monero/common/MoneroConnectionManager.java
@@ -360,7 +360,7 @@ public MoneroConnectionManager checkConnection() {
     MoneroRpcConnection connection = getConnection();
     if (connection != null) {
       if (connection.checkConnection(timeoutMs)) connectionChanged = true;
-      if (processResponses(Arrays.asList(connection)) != null) return this; // done if connection set from responses
+      processResponses(Arrays.asList(connection));
     }
     if (autoSwitch && !isConnected()) {
       MoneroRpcConnection bestConnection = getBestAvailableConnection(connection);

diff --git a/src/test/java/TestMoneroConnectionManager.java b/src/test/java/TestMoneroConnectionManager.java
@@ -168,10 +168,9 @@ public void testConnectionManager() throws InterruptedException, IOException {
       assertEquals(++numExpectedChanges, listener.changedConnections.size());
 
       // connect to specific endpoint with authentication
-      connectionManager.setAutoSwitch(false);
       orderedConnections.get(1).setCredentials("rpc_user", "abc123");
       connectionManager.checkConnection();
-      assertEquals(connection.getUri(), walletRpcs.get(1).getRpcConnection().getUri());
+      assertEquals(connectionManager.getConnection().getUri(), walletRpcs.get(1).getRpcConnection().getUri());
       assertTrue(connection.isOnline());
       assertTrue(connection.isAuthenticated());
       assertEquals(++numExpectedChanges, listener.changedConnections.size());
@@ -211,7 +210,6 @@ public void testConnectionManager() throws InterruptedException, IOException {
       assertEquals(++numExpectedChanges, listener.changedConnections.size());
 
       // check all connections and test auto switch
-      connectionManager.setAutoSwitch(true);
       connectionManager.checkConnections();
       assertEquals(++numExpectedChanges, listener.changedConnections.size());
       assertTrue(connectionManager.isConnected());