feat: adds case-insensitive template matching for uses actions #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodruffw
reviewed
Dec 24, 2024
src/models.rs
Outdated
Comment on lines
630
to
631
| self.owner.to_lowercase() == other.owner.to_lowercase() | ||
| && self.repo.to_lowercase() == other.repo.to_lowercase() |
There was a problem hiding this comment.
The owner and repo could probably be compared with eq_ignore_ascii_case instead, to avoid a few allocations (since GH requires both to be ASCII).
The subpath and git_ref can be anything OTOH, so those look good to me!
There was a problem hiding this comment.
Awesome input, justed learned about another small gem in Rust std 🙂
Done here
woodruffw
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #334
Improves the implementation of
RepositoryUses::matchesso it becomes case-insensitive regarding a provided template.I opted for case-insensitive comparisons rather than normalizing to a lowercased template because I see this approach introducing less changes, and all of them live within a single function.