Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle context accesses following calls #340

Merged
merged 10 commits into from
Dec 21, 2024
Merged

fix: handle context accesses following calls #340

merged 10 commits into from
Dec 21, 2024

Conversation

woodruffw
Copy link
Owner

@woodruffw woodruffw commented Dec 20, 2024

WIP; These grammar changes mean the syntax tree itself is different, so I need to update the walk as well.

Fixes #339.

@woodruffw woodruffw added the bugfix Fixes a known bug label Dec 20, 2024
@woodruffw woodruffw self-assigned this Dec 20, 2024
@woodruffw
Copy link
Owner Author

Some notes for myself:

  • The Context node is now insufficiently expressive: an expression like fromJson(steps.runs.outputs.data).workflow_runs[0].id should be:
Context
  Call { fromJson args: Context { lit:steps, lit:runs, lit:outputs, lit:data } }
  lit:workflow_runs
  Index { 0 }
  lit:id

@woodruffw woodruffw marked this pull request as ready for review December 21, 2024 01:41
@woodruffw woodruffw merged commit 7a87adb into main Dec 21, 2024
5 checks passed
@woodruffw woodruffw deleted the ww/bug-339 branch December 21, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a known bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: couldn't parse expression: fromJson(...)
1 participant