feat: improves expression expansion when handling matrices #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubiratansoares
commented
Dec 5, 2024
ubiratansoares
commented
Dec 5, 2024
ubiratansoares
commented
Dec 5, 2024
|
Thanks for tackling this @ubiratansoares! I've been procrastinating on improving things here 😅 -- I'll do a quick pass now and then a more detailed on later today/tomorrow. |
ubiratansoares
commented
Dec 5, 2024
woodruffw
reviewed
Dec 5, 2024
woodruffw
reviewed
Dec 5, 2024
ubiratansoares
force-pushed
the
ufs/patch-09
branch
from
a46b396 to
e28d18f
Compare
|
@woodruffw Fixed all the conflicts and addressed some comments! Impressed by the amount of stuff that happened since Friday, btw 😄 |
ubiratansoares
force-pushed
the
ufs/patch-09
branch
from
b132d8c to
c67830f
Compare
ubiratansoares
commented
Dec 8, 2024
ubiratansoares
force-pushed
the
ufs/patch-09
branch
from
377f3e1 to
686b966
Compare
woodruffw
reviewed
Dec 10, 2024
woodruffw
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Thanks @ubiratansoares, this LGTM! One nitpick but otherwise we're good to go.
Signed-off-by: William Woodruff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to #114
There are a couple of improvements here, but at least we have a working implementation. I've added snapshot tests to exercise different scenarios for
self-hostedaudit andtemplate-injectionas well.See some comments below. Happy to get input here and interate over them 🙂
Closes #114