-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds support to inlined ignores #187
Conversation
Thanks @ubiratansoares! I like the (Apologies for the merge, that was a force of habit. If it makes things annoying here, please feel free to force-push over it.) |
a387aa7
to
0de3177
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ubiratansoares!
I think I'd like to see #187 (comment) in this PR, but otherwise everything looks fantastic to me (and we can start follow-up issues/PRs for the other things).
0de3177
to
0edaf5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ubiratansoares!
Closes #124
There are 2 approaches here
FindingRegistry
levelFindingBuilder
levelIn both of them the core remains the same :
Workflow
Finding.location
to extract the start and end rows related to the impacted snippetHappy to iterate on this idea. If one of them makes sense, happy to add a commit with proper docs
How to test