feat: unsecure-commands-allowed audit #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing this PR :
cargo run -- tests/test-data/unsecure-commands-allowed.yml |
woodruffw
reviewed
Nov 19, 2024
There was a problem hiding this comment.
Thanks @ubiratansoares, this looks fantastic! A couple of small comments/nitpicks.
(Could you also add a docs section for this new audit, under the pre-existing audit.md? The other documentation there should be a good reference!)
|
@woodruffw Added some docs here. Hope everything looks fine 🚀 |
|
Thanks a ton @ubiratansoares, this looks great! I'll take over the PR to do a bit of small polishing, and then merge it. |
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
woodruffw
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
unsecure-commands-allowed, as per described in #171We should be able to detect opt-in for
ACTIONS_ALLOW_UNSECURE_COMMANDSin all possible contexts, namelyworkflow.env,job.envandstep.env. I covered both reusable and normal jobs, hope I did not miss anything. Added some integration tests as well.Closes #171