Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error parsing github actions workflow #64

Closed
mcpherrinm opened this issue Oct 28, 2024 · 4 comments · Fixed by #65
Closed

Error parsing github actions workflow #64

mcpherrinm opened this issue Oct 28, 2024 · 4 comments · Fixed by #65
Labels
bug Something isn't working

Comments

@mcpherrinm
Copy link

I tried to run zizmor on https://github.com/letsencrypt/boulder/blob/main/.github/workflows/boulder-ci.yml

I got the following error:

% zizmor .
Error: invalid GitHub Actions workflow: "/src/boulder/.github/workflows/boulder-ci.yml"

Caused by:
    jobs: data did not match any variant of untagged enum Job at line 28 column 3

I believe this is job is valid as it works. Without reading the zizmor source, I'm not sure what enum it's expecting to match. Line 28 col 3 is the name of the job.

@woodruffw
Copy link
Owner

Thanks @mcpherrinm! That's almost certainly a bug in https://github.com/woodruffw/github-actions-models -- I'll debug.

@woodruffw
Copy link
Owner

woodruffw/github-actions-models#8 will fix this -- the underlying problem is that strategy doesn't require a matrix, even though the JSON Schema for GitHub Workflows (source) implies it does.

woodruffw added a commit that referenced this issue Oct 28, 2024
This fixes #64 by fixing our parsing of jobs
that contain a `strategy` but no `matrix`.

Signed-off-by: William Woodruff <[email protected]>
@woodruffw
Copy link
Owner

Bump and full fix is in #65, and I've confirmed it works for me locally. Thanks for the report @mcpherrinm!

@mcpherrinm
Copy link
Author

Thanks! zizmor now successfully parses all the repos I have locally at least!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants