Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: SARIF paths are still borked #468

Closed
2 tasks done
woodruffw opened this issue Jan 18, 2025 · 0 comments · Fixed by #469
Closed
2 tasks done

[BUG]: SARIF paths are still borked #468

woodruffw opened this issue Jan 18, 2025 · 0 comments · Fixed by #469
Assignees
@woodruffw
Labels
bug Something isn't working

Comments

@woodruffw
Copy link
Owner

Pre-submission checks

  • I am not filing a feature request. These should be filed via the feature request form instead.
  • I have looked through the open issues for a duplicate report.

Expected behavior

SARIF previews on GitHub should work for action definitions in non-trivial locations.

Actual behavior

I was hoping that GitHub's SARIF support would understand absolute paths on its own GHA runners, but it looks like I was wrong about that:

Reproduction steps

N/A

Logs

Additional context

No response
@woodruffw woodruffw added the bug Something isn't working label Jan 18, 2025
@woodruffw woodruffw self-assigned this Jan 18, 2025
woodruffw added a commit that referenced this issue Jan 18, 2025
@woodruffw
bugfix: generalize path prefix handling
1bf75f9 
Fixes #468.
@woodruffw woodruffw mentioned this issue Jan 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@woodruffw woodruffw

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bugfix: generalize path prefix handling woodruffw/zizmor
1 participant
@woodruffw