Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trophy case should accept individual commit links #302

Closed
girlbossceo opened this issue Dec 15, 2024 · 3 comments · Fixed by #303
Closed

Trophy case should accept individual commit links #302

girlbossceo opened this issue Dec 15, 2024 · 3 comments · Fixed by #303
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@girlbossceo
Copy link

Hi! I came across zizmor when I heard about Ultralytics, and I used zizmor on my repo with 573 stars, and I would like to add it to the trophy case but it only supports PR links where as I typically do a lot of work in one PR and merge it (we're a fast-moving project).

Is it possible for the trophy case to support adding a commit link like this?

girlbossceo/conduwuit@c6bf8f5

@woodruffw
Copy link
Owner

Thanks @girlbossceo! I haven't tested it, but I suspect that kind of direct commit slug should also work and I'd be happy to include it! Please send a PR if you have time; otherwise I can mess around with it later today 🙂

@girlbossceo
Copy link
Author

It looks like it just gets skipped over by render-trophies.py no matter which way I put it.

Adding this in trophies.txt: girlbossceo/conduwuit/commit/c6bf8f5ea15a6b963220a1de4bb50a639d0d0696
Outputs:

❯ make trophies
make: Nothing to be done for `trophies'.

Adding the full URL outputs:

uv run --no-project docs/snippets/render-trophies.py > docs/snippets/trophies.md
Traceback (most recent call last):
  File "/Users/strawberry/zizmor/docs/snippets/render-trophies.py", line 23, in <module>
    org, rest = trophy.split("/")
    ^^^^^^^^^
ValueError: too many values to unpack (expected 2)
make: *** [docs/snippets/trophies.md] Error 1

@woodruffw
Copy link
Owner

Whoops, that's my bad! I've tweaked the trophy generation and added your project here #303. Thanks for bringing this to my attention!

@woodruffw woodruffw added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants