Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: "(0 ignored)" seems superfluous #147

Closed
2 tasks done
nedbat opened this issue Nov 10, 2024 · 4 comments · Fixed by #148 or #157
Closed
2 tasks done

Feature: "(0 ignored)" seems superfluous #147

nedbat opened this issue Nov 10, 2024 · 4 comments · Fixed by #148 or #157
Labels
enhancement New feature or request

Comments

@nedbat
Copy link

nedbat commented Nov 10, 2024

Pre-submission checks

  • I am not a bug (crash, false positive/negative, etc). These must be filed via the bug report template.
  • I have looked through the open issues for a duplicate request.

What's the problem this feature will solve?

I get results like:

No findings to report. Good job! (0 ignored)

I think the message would be a clearer celebration of success as just:

No findings to report. Good job!

Describe the solution you'd like

If there are ignored findings, of course, include the ignored count. But "0 ignored" doesn't seem like something to mention.

Additional context

No response

@nedbat nedbat added the enhancement New feature or request label Nov 10, 2024
@woodruffw
Copy link
Owner

Agreed, that's completely superfluous. I'll look at removing it!

woodruffw added a commit that referenced this issue Nov 10, 2024
Adds zero information to the output.

Fixes #147.
@woodruffw
Copy link
Owner

#148 will address this.

woodruffw added a commit that referenced this issue Nov 10, 2024
Adds zero information to the output.

Fixes #147.
@nedbat
Copy link
Author

nedbat commented Nov 14, 2024

Thanks, but I installed 0.3.1 and still see the "(0 ignored)" messages.

@woodruffw
Copy link
Owner

🤦 I removed the wrong (0 ignored) message. Sorry about that, I'll also remove that one when it's superfluous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants