Skip to content

Surface .env load errors #6707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
6543 merged 4 commits into from
Jun 8, 2026
Merged

Surface .env load errors #6707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cecb92e
Load .env explizite and error out on issue
6543 Jun 6, 2026
34bc381
Fprintf
6543 Jun 6, 2026
8502b18
imports
6543 Jun 6, 2026
76732c3
cspell
6543 Jun 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .cspell.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@
"gocritic",
"GODEBUG",
"godoc",
"godotenv",
"Gogs",
"golangci",
"gomod",
Expand Down
2 changes: 0 additions & 2 deletions cmd/agent/core/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ import (
"os"
"slices"

// Load config from .env file.
_ "github.com/joho/godotenv/autoload"
"github.com/rs/zerolog/log"
"github.com/urfave/cli/v3"

Expand Down
8 changes: 8 additions & 0 deletions cmd/agent/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@ package main

import (
"context"
"fmt"
"os"

"github.com/joho/godotenv"
"github.com/rs/zerolog/log"

"go.woodpecker-ci.org/woodpecker/v3/cmd/agent/core"
Expand All @@ -34,6 +37,11 @@ var backends = []backend_types.Backend{
}

func main() {
if err := godotenv.Load(); err != nil {
fmt.Fprintf(os.Stderr, "Error could not load .env: %s", err)
os.Exit(1)
}

ctx := utils.WithContextSigtermCallback(context.Background(), func() {
log.Info().Msg("termination signal is received, shutting down agent")
})
Expand Down
7 changes: 7 additions & 0 deletions cmd/agent/man.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ package main

import (
"fmt"
"os"

"github.com/joho/godotenv"
docs "github.com/urfave/cli-docs/v3"

"go.woodpecker-ci.org/woodpecker/v3/cmd/agent/core"
Expand All @@ -35,6 +37,11 @@ var backends = []backend_types.Backend{
}

func main() {
if err := godotenv.Load(); err != nil {
fmt.Fprintf(os.Stderr, "Error could not load .env: %s", err)
os.Exit(1)
}

app := core.GenApp(backends)
md, err := docs.ToMan(app)
if err != nil {
Expand Down
8 changes: 7 additions & 1 deletion cmd/cli/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,21 @@ package main

import (
"context"
"fmt"
"os"

_ "github.com/joho/godotenv/autoload"
"github.com/joho/godotenv"
"github.com/rs/zerolog/log"

"go.woodpecker-ci.org/woodpecker/v3/shared/utils"
)

func main() {
if err := godotenv.Load(); err != nil {
fmt.Fprintf(os.Stderr, "Error could not load .env: %s", err)
os.Exit(1)
}

ctx := utils.WithContextSigtermCallback(context.Background(), func() {
log.Info().Msg("termination signal is received, terminate cli")
})
Expand Down
8 changes: 7 additions & 1 deletion cmd/server/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,22 @@ package main

import (
"context"
"fmt"
"os"

_ "github.com/joho/godotenv/autoload"
"github.com/joho/godotenv"
"github.com/rs/zerolog/log"

_ "go.woodpecker-ci.org/woodpecker/v3/cmd/server/openapi"
"go.woodpecker-ci.org/woodpecker/v3/shared/utils"
)

func main() {
if err := godotenv.Load(); err != nil {
fmt.Fprintf(os.Stderr, "Error could not load .env: %s", err)
os.Exit(1)
}

ctx := utils.WithContextSigtermCallback(context.Background(), func() {
log.Info().Msg("termination signal is received, shutting down server")
})
Expand Down
8 changes: 7 additions & 1 deletion cmd/server/man.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,20 @@ package main

import (
"fmt"
"os"

_ "github.com/joho/godotenv/autoload"
"github.com/joho/godotenv"
docs "github.com/urfave/cli-docs/v3"

_ "go.woodpecker-ci.org/woodpecker/v3/cmd/server/openapi"
)

func main() {
if err := godotenv.Load(); err != nil {
fmt.Fprintf(os.Stderr, "Error could not load .env: %s", err)
os.Exit(1)
}

app := genApp()
md, err := docs.ToMan(app)
if err != nil {
Expand Down