Skip to content

pipeline: use more explizite error for step dependencies filtered out by its conditions#6680

Merged
lafriks merged 1 commit into
woodpecker-ci:mainfrom
6543-forks:ux-error-message-dag-dep-checker
May 31, 2026
Merged

pipeline: use more explizite error for step dependencies filtered out by its conditions#6680
lafriks merged 1 commit into
woodpecker-ci:mainfrom
6543-forks:ux-error-message-dag-dep-checker

Conversation

@6543

@6543 6543 commented May 30, 2026

Copy link
Copy Markdown
Member

close #6667

@6543 6543 added enhancement improve existing features ux user experience labels May 30, 2026
@codecov

codecov Bot commented May 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.59%. Comparing base (a765cb8) to head (c3becd3).

Files with missing lines Patch % Lines
pipeline/frontend/yaml/compiler/errors.go 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6680      +/-   ##
==========================================
- Coverage   42.61%   42.59%   -0.03%     
==========================================
  Files         436      436              
  Lines       29115    29131      +16     
==========================================
- Hits        12408    12407       -1     
- Misses      15599    15613      +14     
- Partials     1108     1111       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@qwerty287

Copy link
Copy Markdown
Contributor

The step hasn't necessarily been filtered out, it's also possible that the step just does not exist I think (e.g. due to a typo)

@6543

6543 commented May 31, 2026

Copy link
Copy Markdown
Member Author

yes in this case the old error message stays ... should i also change it's text to be more clear?

@qwerty287 qwerty287 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah sorry, missed that. Is ok then

@lafriks lafriks merged commit 7f46a5d into woodpecker-ci:main May 31, 2026
8 of 9 checks passed
@woodpecker-bot woodpecker-bot mentioned this pull request May 31, 2026
1 task
@6543 6543 deleted the ux-error-message-dag-dep-checker branch May 31, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement improve existing features ux user experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Too generic error message when step is not present in DAG

3 participants