fix(kubernetes): services should have clean exit state from WaitStep on context expiry/API server errors#6669
Open
hhamalai wants to merge 1 commit into
Open
Conversation
There's a corner case where the pipeline service on Kubernetes backend is not cleaned up appropriately when the context is cancelled, leading to services being shown as running, even while the service pods are terminated. Also the DestroyWorkflow changed to handler destroying steps with errgroup like handled out with Docker backend, instead of failing on the first error.
Member
|
Does #6672 solfe this here? |
Contributor
Author
The usage of error groups in DestroyWorkflow step would unify the logic with kubernetes/docker runners a bit. It's by no mean complete refactoring, but such refactoring would make maintaining these different backends a bit more straightforward in long run? |
6543
reviewed
Jun 1, 2026
| case <-finished: | ||
| case <-ctx.Done(): | ||
| return nil, ctx.Err() | ||
| return &types.State{ExitCode: 0, Exited: true}, nil |
Member
There was a problem hiding this comment.
TODO: make sure we dont get success state in killed steps by cancle
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a corner case(s) where the pipeline service on Kubernetes backend is not cleaned up appropriately when the context is cancelled, leading to services being shown as running, even while the service pods are terminated.
Also the DestroyWorkflow changed to handler destroying steps with errgroup like handled out with Docker backend, instead of failing on the first error.