Fix org lookup panic

server/api/org.go

@@ -127,15 +127,27 @@ func LookupOrg(c *gin.Context) {
 
 	orgFullName := strings.TrimLeft(c.Param("org_full_name"), "/")
 
-	org, err := _store.OrgFindByName(orgFullName, user.ForgeID)
-	if err != nil {
-		handleDBError(c, err)
-		return
+	var org *model.Org
+	if user == nil {
+		org, err = _store.OrgLookup(orgFullName)
+		if err != nil {
+			if err.Error() == "found more than one org with this name" {
+				_ = c.AbortWithError(http.StatusBadRequest, err)
+				return
+			}
+			handleDBError(c, err)
+			return
+		}
+	} else {
+		org, err = _store.OrgFindByName(orgFullName, user.ForgeID)
+		if err != nil {
+			handleDBError(c, err)
+			return
+		}
 	}
 
 	// don't leak private org infos
 	if org.Private {
-		user := session.User(c)
 		if user == nil {
 			c.AbortWithStatus(http.StatusNotFound)
 			return

server/store/datastore/org.go

@@ -21,6 +21,7 @@ import (
 	"xorm.io/xorm"
 
 	"go.woodpecker-ci.org/woodpecker/v3/server/model"
+	"go.woodpecker-ci.org/woodpecker/v3/server/store/types"
 )
 
 func (s storage) OrgCreate(org *model.Org) error {
@@ -82,6 +83,22 @@ func (s storage) orgFindByName(sess *xorm.Session, name string, forgeID int64) (
 	return org, wrapGet(sess.Where("LOWER(name) = ?", strings.ToLower(name)).And("forge_id = ?", forgeID).Get(org))
 }
 
+func (s storage) OrgLookup(name string) (*model.Org, error) {
+	var orgs []*model.Org
+	// we limit to 2 orgs, if we have >= 2 we return an error anyways.
+	err := s.engine.Where("LOWER(name) = ?", strings.ToLower(name)).Limit(2).Find(&orgs) //nolint:mnd
+	if err != nil {
+		return nil, err
+	}
+	if len(orgs) < 1 {
+		return nil, types.ErrRecordNotExist
+	}
+	if len(orgs) > 1 {
+		return nil, fmt.Errorf("found more than one org with this name")
+	}
+	return orgs[0], nil
+}
+
 func (s storage) OrgRepoList(org *model.Org, p *model.ListOptions) ([]*model.Repo, error) {
 	var repos []*model.Repo
 	return repos, s.paginate(p).OrderBy("id").Where("org_id = ?", org.ID).Find(&repos)

server/store/store.go

@@ -195,6 +195,7 @@ type Store interface {
 	OrgCreate(*model.Org) error
 	OrgGet(int64) (*model.Org, error)
 	OrgFindByName(string, int64) (*model.Org, error)
+	OrgLookup(string) (*model.Org, error)
 	OrgUpdate(*model.Org) error
 	OrgDelete(int64) error
 	OrgList(*model.ListOptions) ([]*model.Org, error)