Add commit timestamp environment variables#6635
Closed
AkashKumar7902 wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thanks to be consistent with other vars like |
6543
reviewed
May 26, 2026
Member
|
also cli needs patch to allow setting it |
Contributor
|
added cli and changed to unix timstamps in #6670 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI_COMMIT_TIMESTAMPandCI_PREV_COMMIT_TIMESTAMPas UTC RFC3339 values when commit timestamps are availableCloses #5245
Validation
go test -race -tags test ./pipeline/frontend/metadata ./server/pipeline/metadata -run 'TestEnviron|TestGetWorkflowMetadata' -count=1 -vgo test -race -tags test ./pipeline/frontend/metadata ./server/pipeline/... -count=1make test-libmake test-server