Skip to content

Pin pnpm to v10.33.4#6559

Merged
lafriks merged 3 commits into
mainfrom
pin-pnpm
May 9, 2026
Merged

Pin pnpm to v10.33.4#6559
lafriks merged 3 commits into
mainfrom
pin-pnpm

Conversation

@6543

@6543 6543 commented May 9, 2026

Copy link
Copy Markdown
Member

Upstream node LTS image was updated with a newer Corepack whose default
"known good" pnpm version jumped to v11. Because we had no packageManager
field in package.json, Corepack fell back to that default and silently
bumped pnpm to v11 without any explicit change on our side.

Our tooling does not support pnpm v11 yet, which broke CI.

The fix pins pnpm explicitly so we no longer rely on Corepack's moving
default. Renovate will keep the pinned version up to date going forward.

Also updates the nix dev env to the same pinned version for consistency.

Fixes https://ci.woodpecker-ci.org/repos/3780/pipeline/34117

@6543 6543 added bug Something isn't working build CI pipeline related labels May 9, 2026
Comment thread .woodpecker/binaries.yaml Outdated
Comment thread .woodpecker/docker.yaml Outdated
Comment thread .woodpecker/web.yaml Outdated
Comment thread .woodpecker/docs.yaml Outdated
@6543

This comment was marked as resolved.

6543 added 2 commits May 9, 2026 21:18
Flake lock file updates:

• Updated input 'nixpkgs':
    'github:nixos/nixpkgs/81df7a1e2eefe78b4727c8f3d66293300bf193d1' (2026-04-08)
  → 'github:nixos/nixpkgs/2e8afb433747d87eba54496f93f90f41ee1adeab' (2026-05-09)
@6543 6543 changed the title Pin pnpm to v10 Pin pnpm to v10.33.4 May 9, 2026
@6543 6543 requested a review from a team May 9, 2026 19:26
@woodpecker-bot

woodpecker-bot commented May 9, 2026

Copy link
Copy Markdown
Contributor

Surge PR preview deployment was removed

@xoxys

xoxys commented May 9, 2026

Copy link
Copy Markdown
Member

How was this introduced in the first place? And why does pnpm pinning fixes it?

@6543

6543 commented May 9, 2026

Copy link
Copy Markdown
Member Author

upstream node just chnaged it's default config to serve pnpm version 11

but our tooling is not setup to support it.

if we tell node to use a version we pinned it runs it witj that

so the symptom is pnpm fails the cause is that pnpm was silently bumped to v11

@6543 6543 requested a review from xoxys May 9, 2026 20:20
@6543

6543 commented May 9, 2026

Copy link
Copy Markdown
Member Author

... the cure is to make this not use default setting but our pined config witch renovate now can maintian ...

@xoxys

xoxys commented May 9, 2026

Copy link
Copy Markdown
Member

Thanks. Still wondering why an lts node container silently bumps pnpm major

@6543

6543 commented May 9, 2026

Copy link
Copy Markdown
Member Author

yes! thats breaking behaviour ...

anyway will update the description now to document it better...

@lafriks lafriks merged commit 3d119dd into main May 9, 2026
6 of 7 checks passed
@lafriks lafriks deleted the pin-pnpm branch May 9, 2026 20:30
@woodpecker-bot woodpecker-bot mentioned this pull request May 9, 2026
1 task
@6543

6543 commented May 9, 2026

Copy link
Copy Markdown
Member Author

... updated

6543 added a commit that referenced this pull request May 9, 2026
@6543

6543 commented May 9, 2026

Copy link
Copy Markdown
Member Author

nice now renovate does it's job: #6561

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working build CI pipeline related skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants