Fix workflow hang on services#6507
Merged
Merged
Conversation
6543
commented
Apr 26, 2026
Contributor
|
Surge PR preview deployment was removed |
xoxys
approved these changes
Apr 27, 2026
Member
Author
|
thx & sorry that i did not catched such easy bug first ... |
Member
|
No worries. Happens, as I approved it I could have tested it better as well. However, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #6506 ; regression of #6471
because we now wait for all steps to trace status back before we return, the defere did not tear down services anymore ...
... we now explicit tear down services and steps after all stages have executed.
I also added tests to check for that and update the dummy backend to fullfill the interface contract of killing all "running" steps with DestroyWorkflow