Skip to content

saveWorkflowsFromPipelineBuilder: check for pre-loaded workflows #6474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
6543 merged 1 commit into from
May 13, 2026
+6 −3
Merged

saveWorkflowsFromPipelineBuilder: check for pre-loaded workflows #6474

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions server/pipeline/items.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,9 +210,12 @@ func saveWorkflowsFromPipelineBuilder(store store.Store, pipeline *model.Pipelin
}
}

// the workflows in the pipeline should be empty as only we do populate them,
// but if a pipeline was already loaded form database it might contain things, so we just clean it
pipeline.Workflows = nil
// The workflows in the pipeline should be empty, only we populate them.
// But if a pipeline was already loaded from the database and contains workflows,
// we error out to prevent harm.
if pipeline.Workflows != nil {
return nil, errors.New("cannot save new workflows from pipeline builder: pipeline already has workflows loaded")
}

for _, item := range pipelineItems {
workflow := &model.Workflow{
Expand Down