Fix race condition in event stream channel handling#6455
Closed
utafrali wants to merge 2 commits into
Closed
Conversation
hhamalai
reviewed
Apr 16, 2026
This comment was marked as off-topic.
This comment was marked as off-topic.
Contributor
|
Surge PR preview deployment was removed |
Contributor
Author
|
Done, pushed the fix. |
Member
|
now I dont know why there are tow pulls working on the same issue by the same people either authored or reviewed!?!? -> #6456 |
Contributor
Author
|
Ah yeah, I'll close this since #6456 is already on it. |
Member
|
still thanks for the fix |
|
FYI, OP is a bot: concourse/concourse#9532 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6454
We were getting panics when clients disconnected from SSE feeds because the code was closing the channel while goroutines could still be trying to send on it.
The fix removes the explicit close() calls and refactors the select statements so that context cancellation and channel sends happen atomically. If the context is cancelled, we skip the send. The channel gets garbage collected naturally after all goroutines exit the context.
Added a concurrent stress test to make sure this doesn't happen again.