Skip to content

Enhance datastore DB test setup #6450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
6543 merged 1 commit into from
Apr 15, 2026
Merged

Enhance datastore DB test setup #6450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion server/store/datastore/engine_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,16 @@ func testDriverConfig() (driver, config string) {
// newTestStore creates a new database connection for testing purposes.
// The database driver and connection string are provided by
// environment variables, with fallback to in-memory sqlite.
func newTestStore(t *testing.T, tables ...any) (*storage, func()) {
func newTestStore(t *testing.T, tables ...any) (store *storage, closer func()) {
engine, err := xorm.NewEngine(testDriverConfig())
require.NoError(t, err)

// MaxOpenConns=1 and MaxIdleConns=1 are required for in-memory sqlite:
// without them the pool drops idle connections, destroying the in-memory
// schema between calls and breaking migrations.
engine.SetMaxOpenConns(1)
engine.SetMaxIdleConns(1)

for _, table := range tables {
if err := engine.Sync(table); err != nil {
t.Error(err)
Expand Down