Kubernetes: detached steps are no services

[6543]

the implementation just assumes, that detached steps are services, witch is wrong

close #5124

[xoxys]

@MartinSchmidt can you take a look?

[xoxys]

Not checked the implementation but how are detached steps now work on kunbernetes. They will be regular pods? Containers in the workflow pod? Do we ensure not not end up with orphanded resources after pipeline exited?

[6543]

woodpecker/pipeline/runtime/workflow.go

Lines 42 to 52 in 3058b85

	// we make sure cleanup always happens
	defer func() {
	ctx := runnerCtx //nolint:contextcheck
	if ctx.Err() != nil {
	// runnerCtx itself is done — fall back to a short-lived shutdown context.
	ctx = GetShutdownCtx()
	}
	if err := r.engine.DestroyWorkflow(ctx, r.spec, r.taskUUID); err != nil {
	logger.Error().Err(err).Msg("could not destroy workflow")
	}
	}()

woodpecker/pipeline/backend/kubernetes/kubernetes.go

Lines 473 to 484 in 3058b85

	// DestroyWorkflow destroys the pipeline environment.
	func (e *kube) DestroyWorkflow(ctx context.Context, conf *types.Config, taskUUID string) error {
	log.Trace().Str("taskUUID", taskUUID).Msg("deleting Kubernetes primitives")
	for _, stage := range conf.Stages {
	for _, step := range stage.Steps {
	err := stopPod(ctx, e, step, defaultDeleteOptions)
	if err != nil {
	return err
	}
	}
	}

[xoxys]

Code lgtm but untested. Thanks for the refs should work.as expected for detached steps.