Skip to content

Fix erroneous linter error for plugin privileges#6424

Merged
qwerty287 merged 4 commits into
woodpecker-ci:mainfrom
packrat386:fix_lint_privileged_plugins
Apr 11, 2026
Merged

Fix erroneous linter error for plugin privileges#6424
qwerty287 merged 4 commits into
woodpecker-ci:mainfrom
packrat386:fix_lint_privileged_plugins

Conversation

@packrat386
Copy link
Copy Markdown
Contributor

Currently if you use one of the plugins from the list that were formerly privileged by default and you explicitly configure that step with privileged: true you still get a linter error prompting you to add those to WOODPECKER_PLUGINS_PRIVILEGED. As far as I can tell this error message is incorrect because WOODPECKER_PLUGINS_PRIVILEGED is just a way to make certain images function the same as privileged: true by default.

Currently if you use one of the plugins from the list that were
formerly privileged by default and you explicitly configure that step
with `privileged: true` you still get a linter error prompting you to
add those to WOODPECKER_PLUGINS_PRIVILEGED. As far as I can tell this
error message is incorrect because WOODPECKER_PLUGINS_PRIVILEGED is
just a way to make certain images function the same as `privileged:
true` by default.
Copy link
Copy Markdown
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Would change the if clauses like this

Comment thread pipeline/frontend/yaml/linter/linter.go Outdated
@qwerty287 qwerty287 added the bug Something isn't working label Apr 11, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 35.32%. Comparing base (7efe8bf) to head (89336ab).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6424      +/-   ##
==========================================
- Coverage   35.46%   35.32%   -0.14%     
==========================================
  Files         427      429       +2     
  Lines       28650    28759     +109     
==========================================
  Hits        10160    10160              
- Misses      17560    17669     +109     
  Partials      930      930              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@qwerty287 qwerty287 merged commit 7749f60 into woodpecker-ci:main Apr 11, 2026
8 of 9 checks passed
This was referenced Apr 11, 2026
@woodpecker-bot woodpecker-bot mentioned this pull request Apr 27, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants