Fix erroneous linter error for plugin privileges#6424
Merged
qwerty287 merged 4 commits intoApr 11, 2026
Conversation
Currently if you use one of the plugins from the list that were formerly privileged by default and you explicitly configure that step with `privileged: true` you still get a linter error prompting you to add those to WOODPECKER_PLUGINS_PRIVILEGED. As far as I can tell this error message is incorrect because WOODPECKER_PLUGINS_PRIVILEGED is just a way to make certain images function the same as `privileged: true` by default.
qwerty287
reviewed
Apr 11, 2026
Contributor
qwerty287
left a comment
There was a problem hiding this comment.
Thanks! Would change the if clauses like this
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6424 +/- ##
==========================================
- Coverage 35.46% 35.32% -0.14%
==========================================
Files 427 429 +2
Lines 28650 28759 +109
==========================================
Hits 10160 10160
- Misses 17560 17669 +109
Partials 930 930 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
qwerty287
approved these changes
Apr 11, 2026
This was referenced Apr 11, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if you use one of the plugins from the list that were formerly privileged by default and you explicitly configure that step with
privileged: trueyou still get a linter error prompting you to add those to WOODPECKER_PLUGINS_PRIVILEGED. As far as I can tell this error message is incorrect because WOODPECKER_PLUGINS_PRIVILEGED is just a way to make certain images function the same asprivileged: trueby default.