Skip to content

Fix pipeline cancel#6320

Merged
6543 merged 56 commits into
woodpecker-ci:mainfrom
6543-forks:fix-cancel
Mar 30, 2026
Merged

Fix pipeline cancel#6320
6543 merged 56 commits into
woodpecker-ci:mainfrom
6543-forks:fix-cancel

Conversation

@6543
Copy link
Copy Markdown
Member

@6543 6543 commented Mar 24, 2026

close #6184

6543 and others added 30 commits February 27, 2026 20:46
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: Anbraten <6918444+anbraten@users.noreply.github.com>
@6543 6543 self-assigned this Mar 24, 2026
@6543 6543 changed the title WIP: Fix cancel Fix pipeline cancel Mar 24, 2026
@6543 6543 added the regression fix a bug that was not released yet label Mar 24, 2026
@woodpecker-bot
Copy link
Copy Markdown
Contributor

woodpecker-bot commented Mar 24, 2026

Surge PR preview deployment succeeded. View it at https://woodpecker-ci-woodpecker-pr-6320.surge.sh

@qwerty287 qwerty287 added the blocked something external is blocking it label Mar 25, 2026
Comment thread pipeline/runtime/workflow.go Outdated
Comment thread pipeline/backend/docker/docker.go
Comment thread agent/runner.go
Comment thread server/queue/fifo.go
@6543 6543 removed the blocked something external is blocking it label Mar 30, 2026
@6543 6543 requested a review from a team March 30, 2026 13:12
@6543
Copy link
Copy Markdown
Member Author

6543 commented Mar 30, 2026

☝️ needs review feedback :)

Copy link
Copy Markdown
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix seems fine, but not tested from my side

Comment thread pipeline/runtime/workflow.go Outdated
@6543
Copy link
Copy Markdown
Member Author

6543 commented Mar 30, 2026

now with root cause fix:

cancled

image

successful failed

image

sucessfull success

image

@6543
Copy link
Copy Markdown
Member Author

6543 commented Mar 30, 2026

I dislike the current queue interface anywa... I will refactor this away with #6317

@6543 6543 merged commit af471c5 into woodpecker-ci:main Mar 30, 2026
6 of 7 checks passed
@6543 6543 deleted the fix-cancel branch March 30, 2026 17:33
6543 pushed a commit to woodpecker-ci/infrastructure that referenced this pull request Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

regression fix a bug that was not released yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kubernetes backend continues to execute on cancelled pipeline execution

3 participants