feat(ui): show global/org registries in repo/org registries tab#6296
Closed
mendarb wants to merge 1 commit into
Closed
feat(ui): show global/org registries in repo/org registries tab#6296mendarb wants to merge 1 commit into
mendarb wants to merge 1 commit into
Conversation
Replicates the existing pattern used for secrets to also show global and organization-level registries in the repository and organization registries tabs as read-only entries with level badges. Changes: - Repo registries tab now loads and displays org and global registries - Org registries tab now loads and displays global registries - RegistryList component shows a badge indicating the registry level - Added locale keys for global/org registry labels Closes woodpecker-ci#5950
Contributor
Contributor
|
| Signal | Points | Detail |
|---|---|---|
| Severe fork surge | 70 | 23 repos forked within 24 hours |
Review with extra care.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5950
Summary
Replicates the existing pattern used for secrets to also show global and organization-level registries in the repository and organization registries tabs as read-only entries with level badges.
Changes
Registries.vue): Now loads registries from repo, org, and global levels using theusePaginationeachparameter (same pattern asSecrets.vue). Deduplicates by address with repo-level taking priority, and sorts by level then address.OrgRegistries.vue): Now loads registries from org and global levels. Global registries are shown as read-only with a badge.RegistryList.vue): Added aBadgecomponent to indicate when a registry comes from the global or organization level (matching the existingSecretList.vuepattern). Edit/delete buttons are hidden for read-only (inherited) registries.en.json): Addedglobal_level_registryandorg_level_registrytranslation keys.How it works
This follows the exact same approach already used for secrets:
usePaginationhook'seachparameter iterates through levels (repo → org → global)edit: falseand shown as read-onlyRegistryEditcomponent already supportsreadonlymode, so clicking a read-only registry shows its details without allowing editsTesting
pnpm typecheckpassespnpm buildpasses