Skip to content

Prevent registering as arbitrary agents with system token#6283

Merged
6543 merged 1 commit into
woodpecker-ci:mainfrom
qwerty287:agent-sys
Mar 21, 2026
Merged

Prevent registering as arbitrary agents with system token#6283
6543 merged 1 commit into
woodpecker-ci:mainfrom
qwerty287:agent-sys

Conversation

@qwerty287

@qwerty287 qwerty287 commented Mar 21, 2026

Copy link
Copy Markdown
Contributor

Prevent that an agent can register as any other agent by its ID if it has the system token.

This is no big thread, just hardening, as if an user has already the system token, he can create new agents anyway as he likes.

@qwerty287 qwerty287 requested a review from a team March 21, 2026 09:34
@codecov

codecov Bot commented Mar 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.40%. Comparing base (6d60849) to head (dd7b6f4).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
server/rpc/auth_server.go 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6283      +/-   ##
==========================================
- Coverage   32.43%   32.40%   -0.03%     
==========================================
  Files         420      420              
  Lines       28320    28326       +6     
==========================================
- Hits         9185     9180       -5     
- Misses      18286    18297      +11     
  Partials      849      849              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@6543 6543 merged commit df6c97d into woodpecker-ci:main Mar 21, 2026
7 of 9 checks passed
@woodpecker-bot woodpecker-bot mentioned this pull request Mar 21, 2026
1 task
@qwerty287 qwerty287 deleted the agent-sys branch March 22, 2026 08:10
@woodpecker-bot woodpecker-bot mentioned this pull request Apr 1, 2026
1 task
@woodpecker-bot woodpecker-bot mentioned this pull request Apr 15, 2026
1 task
@woodpecker-bot woodpecker-bot mentioned this pull request Apr 27, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants