Skip to content

Fix license headers#6205

Merged
6543 merged 19 commits into
woodpecker-ci:mainfrom
qwerty287:license-header
Mar 23, 2026
Merged

Fix license headers#6205
6543 merged 19 commits into
woodpecker-ci:mainfrom
qwerty287:license-header

Conversation

@qwerty287
Copy link
Copy Markdown
Contributor

No description provided.

@qwerty287 qwerty287 added the build CI pipeline related label Mar 6, 2026
@woodpecker-bot
Copy link
Copy Markdown
Contributor

woodpecker-bot commented Mar 6, 2026

Surge PR preview deployment was removed

@lafriks
Copy link
Copy Markdown
Contributor

lafriks commented Mar 6, 2026

I would prefer if we would use just SPDX identifier:

// Copyright 2026 Woodpecker CI Authors.
// SPDX-License-Identifier: Apache-2.0

@qwerty287
Copy link
Copy Markdown
Contributor Author

We can do from my side, but first I'd like to get the linter working.

It's just ignoring that there's a file not having a header… https://ci.woodpecker-ci.org/repos/3780/pipeline/32099/3#L7

It works if I run addlicense locally. Does anyone has an idea what's the issue with it?

@xoxys xoxys self-requested a review March 13, 2026 08:02
Comment thread cmd/cli/app.go
@6543 6543 added the wip label Mar 14, 2026
@qwerty287
Copy link
Copy Markdown
Contributor Author

Finally managed to fix this. https://ci.woodpecker-ci.org/repos/3780/pipeline/32376/3 fails as it should.
Reason: bash doesn't support ** wildcards by default, needs to be enabled.

@qwerty287 qwerty287 removed the wip label Mar 19, 2026
@qwerty287 qwerty287 requested a review from a team March 19, 2026 12:31
@qwerty287
Copy link
Copy Markdown
Contributor Author

@woodpecker-ci/maintainers could I get a review here? The lint step is fixed.

@6543
Copy link
Copy Markdown
Member

6543 commented Mar 23, 2026

nice work!!!

@6543
Copy link
Copy Markdown
Member

6543 commented Mar 23, 2026

VERSION_NUMBER=0.0.0 nfpm package --config ./nfpm/agent.yaml --target dist --packager deb
glob failed: : no matching files
make: *** [Makefile:340: bundle-agent] Error 1

?!? related?

@qwerty287
Copy link
Copy Markdown
Contributor Author

No: #6079 (comment)

@6543
Copy link
Copy Markdown
Member

6543 commented Mar 23, 2026

oh no :/ ... ok

@6543 6543 merged commit 3156cd6 into woodpecker-ci:main Mar 23, 2026
7 of 8 checks passed
@woodpecker-bot woodpecker-bot mentioned this pull request Mar 23, 2026
1 task
@qwerty287 qwerty287 deleted the license-header branch March 23, 2026 13:59
@woodpecker-bot woodpecker-bot mentioned this pull request Apr 1, 2026
1 task
@woodpecker-bot woodpecker-bot mentioned this pull request Apr 15, 2026
1 task
@woodpecker-bot woodpecker-bot mentioned this pull request Apr 29, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build CI pipeline related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants