Fix when.status filter evaluation and add workflow-level support

[qwerty287]

fix #6161

And also allow when.status at workflow level. runs_on is deprecated then.

[woodpecker-bot]

Surge PR preview deployment was removed

[6543]

@qwerty287 hope you don't mind ... i refactored two things :)

-> we often have the usecase of filter unique slices so now there is a generic helper
-> use the official golang deprecation syntax so IDE shows it too

[qwerty287]

It's ok for me, but I don't think we need that UniqSlice… I mean it won't break if someone sets status: [failure, failure]. Wouldn't add extra code for this, but I won't block this of course.

[6543]

I know we have more parts in our codebase where we manually use a map to filter uniq stuff and we can with this slowly adopt it more and more.

I also plan to upstream into golang an slices.Filter or slices.Uniq depending on what is already worked on ...

[6543]

@qwerty287 finisched it ... could you look over the new/changed parts and lgtm them ,,, or give feedback :) ?

[qwerty287]

Seems fine for me now, besides that I still don't like the UniqSlice.

[6543]

in this case as it's your pull I'll just move that out and then merge it

[6543]

the current queue impl. should tollerate duplicates. but still i dont like that impl. details of the parser leak out to other parts.

as it can be done later I move this into another pull/issue/discusion for later

[codecov]

Codecov Report

❌ Patch coverage is 69.44444% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 31.98%. Comparing base (480f673) to head (c53ab7b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pipeline/frontend/yaml/linter/linter.go	21.42%	10 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6183      +/-   ##
==========================================
+ Coverage   31.93%   31.98%   +0.05%     
==========================================
  Files         423      423              
  Lines       28563    28584      +21     
==========================================
+ Hits         9121     9142      +21     
+ Misses      18600    18599       -1     
- Partials      842      843       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[6543]

deployed: https://ci.woodpecker-ci.org/repos/6106/pipeline/1877

[xoxys]

@woodpecker-ci/maintainers this is a breaking change. Working CI pipelines now fail:

Please mark it as such and remember to release a major version bump next if this was not a mistake.

[6543]

it schould be written non breaking :/

so this is a bug of this implementation

[qwerty287]

Oh sorry, this shouldn't fail indeed, only warn. Will check it out later