Skip to content

Add Container Registry credential extension#5852

Closed
techknowlogick wants to merge 5 commits into
woodpecker-ci:mainfrom
commitgo:registry-extension
Closed

Add Container Registry credential extension#5852
techknowlogick wants to merge 5 commits into
woodpecker-ci:mainfrom
commitgo:registry-extension

Conversation

@techknowlogick

Copy link
Copy Markdown
Contributor

The configuration extension already exists, but this one would allow for dynamic addition of container registry credentials being injected into runs. That way you don't need to set static credentials in the database.

I might work on the secrets or environment variables extensions support next.

@lafriks

lafriks commented Dec 11, 2025

Copy link
Copy Markdown
Contributor

Why does the base registry take priority? Imho extension should be priority as they could be more specific

@techknowlogick

Copy link
Copy Markdown
Contributor Author

Why does the base registry take priority? Imho extension should be priority as they could be more specific

fair, I've just updated it so extensions take priority (with repo taking precedence over global)

@qwerty287 qwerty287 added the feature add new functionality label Dec 13, 2025
@qwerty287

Copy link
Copy Markdown
Contributor

Thanks! We also don't need the migration itself, model sync happens automatically.
And it seems there is no UI added here?

@techknowlogick

Copy link
Copy Markdown
Contributor Author

@qwerty287 sounds good. A habit of mine of struct changes in Gitea where any changes get a migration ;)
I'll drop that migration.

As for UI I'm saving that for another PR since I wanted to validate the actual functionality first, and I'm more familiar with the backend code than the UI (so any changes needed I could implement much faster). I figured that for mvp it was fine to go with this route.
If not having UI is a blocker, lmk and I can add it in for this PR:)

@woodpecker-bot

woodpecker-bot commented Dec 16, 2025

Copy link
Copy Markdown
Contributor

Surge PR preview deployment was removed

@qwerty287

Copy link
Copy Markdown
Contributor

@techknowlogick can you fix the linter? https://ci.woodpecker-ci.org/repos/3780/pipeline/30254/35

LGTM otherwise.

@techknowlogick

Copy link
Copy Markdown
Contributor Author

thanks @qwerty287, I've just sent lint fix :)

@xoxys

xoxys commented Dec 17, 2025

Copy link
Copy Markdown
Member

Nice one! But can we add docs? 😬

@qwerty287

Copy link
Copy Markdown
Contributor

Thanks for the work @techknowlogick again! I added UI and docs in #5993.

@qwerty287 qwerty287 closed this Jan 20, 2026
@techknowlogick techknowlogick deleted the registry-extension branch January 20, 2026 22:52
@techknowlogick

Copy link
Copy Markdown
Contributor Author

@qwerty287 thanks to you too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature add new functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants