Skip to content

Fix workflow path filter for GitHub#5721

Merged
qwerty287 merged 2 commits into
woodpecker-ci:mainfrom
chamburr:fix-github-path
Nov 6, 2025
Merged

Fix workflow path filter for GitHub#5721
qwerty287 merged 2 commits into
woodpecker-ci:mainfrom
chamburr:fix-github-path

Conversation

@chamburr

@chamburr chamburr commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

The workflow path filter for conditional execution stopped working for GitHub since v3.11.0 (most probably #5618). As a result, all push workflows are triggered for every commit, even when the paths specified are not changed. This (untested) pull request attempts to fix the bug, which I believe is due to incorrect order of arguments.

@qwerty287 qwerty287 added bug Something isn't working forge/github github forge related labels Nov 6, 2025

@qwerty287 qwerty287 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov

codecov Bot commented Nov 6, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 21.48%. Comparing base (dfd5541) to head (492b6e1).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
server/forge/github/github.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5721   +/-   ##
=======================================
  Coverage   21.48%   21.48%           
=======================================
  Files         428      428           
  Lines       38550    38550           
=======================================
  Hits         8283     8283           
  Misses      29503    29503           
  Partials      764      764           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@qwerty287 qwerty287 merged commit 1432037 into woodpecker-ci:main Nov 6, 2025
9 checks passed
@woodpecker-bot woodpecker-bot mentioned this pull request Nov 6, 2025
1 task
@kapilcdave

Copy link
Copy Markdown

Good job chamburr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working forge/github github forge related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants