Skip to content

Fix secret on new forge#5715

Merged
6543 merged 11 commits into
woodpecker-ci:mainfrom
qwerty287:client-secret
Nov 5, 2025
Merged

Fix secret on new forge#5715
6543 merged 11 commits into
woodpecker-ci:mainfrom
qwerty287:client-secret

Conversation

@qwerty287

@qwerty287 qwerty287 commented Nov 3, 2025

Copy link
Copy Markdown
Contributor

closes #5677

@qwerty287 qwerty287 requested a review from a team November 3, 2025 18:24
@qwerty287 qwerty287 added bug Something isn't working server labels Nov 3, 2025
@woodpecker-bot

woodpecker-bot commented Nov 3, 2025

Copy link
Copy Markdown
Contributor

Surge PR preview deployment was removed

Comment thread server/model/forge.go Outdated
@codecov

codecov Bot commented Nov 3, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 21.34%. Comparing base (dd0f593) to head (73d0b46).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
server/api/forge.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5715   +/-   ##
=======================================
  Coverage   21.33%   21.34%           
=======================================
  Files         426      426           
  Lines       38478    38472    -6     
=======================================
  Hits         8211     8211           
+ Misses      29503    29497    -6     
  Partials      764      764           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread server/model/forge.go Outdated
Comment thread server/model/forge.go Outdated
6543 and others added 3 commits November 4, 2025 13:10
Co-authored-by: Anbraten <6918444+anbraten@users.noreply.github.com>
Co-authored-by: Anbraten <6918444+anbraten@users.noreply.github.com>

@6543 6543 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested - still not stored onto DB :/

@6543

6543 commented Nov 4, 2025

Copy link
Copy Markdown
Member

PS: thanks for looking into it

@qwerty287

Copy link
Copy Markdown
Contributor Author

tested - still not stored onto DB :/

Yes you renamed the JSON field in the backend but not the frontend. It worked before.

@xoxys

xoxys commented Nov 4, 2025

Copy link
Copy Markdown
Member

It's IMO a bad practice in general to modify PRs people are actively working on (at least for me).

@6543

6543 commented Nov 4, 2025

Copy link
Copy Markdown
Member

It's IMO a bad practice in general to modify PRs people are actively working on (at least for me).

good question, i do edit stuff when i think i can help with it ... in this case it did the oposit ...

@6543 6543 merged commit 26fc51b into woodpecker-ci:main Nov 5, 2025
8 of 9 checks passed
@6543

6543 commented Nov 5, 2025

Copy link
Copy Markdown
Member

thanks!!!

@woodpecker-bot woodpecker-bot mentioned this pull request Nov 5, 2025
1 task
@qwerty287 qwerty287 deleted the client-secret branch November 5, 2025 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fail to auth users from manuall added gitea forge

5 participants