Add enhanced function for error message handling in http request for configuration fetching

[LUKIEYF]

closes #5292

1. add enhanced function for error handler to log out the exact reason that the config is failed to fetch

2. once the http status is not correct in certain status code and the old config data is available, use the old config data and log the message to warn the user.

3. related enhancedHttpError() function testing codes and related createPipeline() function scenarios testings are added.

please kindly review and give the comments, thank you all! : )

[woodpecker-bot]

Surge PR preview deployment was removed

[6543]

please dont include issue number in title

[qwerty287]

Hi @LUKIEYF sorry for not coming back to you for a long time. Can you check the linter and the tests?

[LUKIEYF]

Hi @LUKIEYF sorry for not coming back to you for a long time. Can you check the linter and the tests?

No problem, buddy. Will do on Monday as soon as possible. :)

[LUKIEYF]

The linter and test case issues are solved, please review. thank you!

[6543]

the server/services/utils/http_error.go is quite extensive. I wonder if we could reuse it in other woodpecker code paths too ...

[codecov]

Codecov Report

❌ Patch coverage is 42.47788% with 65 lines in your changes missing coverage. Please review.
✅ Project coverage is 21.75%. Comparing base (87230ad) to head (757f58f).

Files with missing lines	Patch %	Lines
server/services/utils/http_error.go	44.21%	39 Missing and 14 partials ⚠️
server/pipeline/create.go	0.00%	8 Missing ⚠️
server/services/config/http.go	66.66%	2 Missing and 1 partial ⚠️
server/services/utils/http.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5712      +/-   ##
==========================================
+ Coverage   21.61%   21.75%   +0.14%     
==========================================
  Files         428      429       +1     
  Lines       38738    38844     +106     
==========================================
+ Hits         8372     8450      +78     
- Misses      29596    29604       +8     
- Partials      770      790      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[LUKIEYF]

the server/services/utils/http_error.go is quite extensive. I wonder if we could reuse it in other woodpecker code paths too ...

I have moved the http_error.go and http_error_test.go to the /shared/httputil, please see whether it is proper. thank you!

[6543]

The endpoint should be removed from all errors in this method as well and shouldn't be necessary in the method anymore.

it is just used to grap the host name

[qwerty287]

@6543 no. If there's an error, it is set to the full endpoint.

I still consider this a security risk, nothing critical, but I would not return that endpoint in the error. And it's also possible that the admin would like to hide the host as well.