Skip to content

Fix nil pointer dereference during GitHub Hook parsing#5681

Merged
anbraten merged 1 commit into
woodpecker-ci:mainfrom
6543-forks:github-stacktrace
Oct 23, 2025
Merged

Fix nil pointer dereference during GitHub Hook parsing#5681
anbraten merged 1 commit into
woodpecker-ci:mainfrom
6543-forks:github-stacktrace

Conversation

@6543

@6543 6543 commented Oct 23, 2025

Copy link
Copy Markdown
Member

close #5680
regression of #5618

@6543 6543 added bug Something isn't working server forge/github github forge related regression fix a bug that was not released yet labels Oct 23, 2025
@6543 6543 requested a review from xoxys October 23, 2025 17:35
@xoxys xoxys changed the title github: fix if pipeline is nil Fix nil pointer dereference during GitHub Hook parsing Oct 23, 2025
@xoxys xoxys removed the regression fix a bug that was not released yet label Oct 23, 2025
@codecov

codecov Bot commented Oct 23, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.23%. Comparing base (6fa1635) to head (4e97bc7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5681   +/-   ##
=======================================
  Coverage   21.23%   21.23%           
=======================================
  Files         423      423           
  Lines       38280    38280           
=======================================
  Hits         8130     8130           
  Misses      29396    29396           
  Partials      754      754           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xoxys

xoxys commented Oct 23, 2025

Copy link
Copy Markdown
Member

It can only be a bug or a regression. As the PR that introduced this issue was released already its a bug - regression label removed.

@anbraten anbraten merged commit fbaa339 into woodpecker-ci:main Oct 23, 2025
9 checks passed
@woodpecker-bot woodpecker-bot mentioned this pull request Oct 23, 2025
1 task
@6543 6543 deleted the github-stacktrace branch October 23, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working forge/github github forge related server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

github forge stacktrace

3 participants