Skip to content

Improve error message when agent fails to connect #5587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xoxys merged 2 commits into from
Oct 1, 2025
Merged

Improve error message when agent fails to connect #5587

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
853357a
Improve error message when agent fails to connect
marcusramberg Oct 1, 2025
af1bee1
Merge branch 'main' into marcus/improve_agent_error
xoxys Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cmd/agent/core/agent.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ func run(ctx context.Context, c *cli.Command, backends []types.Backend) error {
authClient := agent_rpc.NewAuthGrpcClient(authConn, agentToken, agentConfig.AgentID)
authInterceptor, err := agent_rpc.NewAuthInterceptor(grpcClientCtx, authClient, authInterceptorRefreshInterval) //nolint:contextcheck
if err != nil {
return fmt.Errorf("could not create new auth interceptor: %w", err)
return fmt.Errorf("agent could not auth: %w", err)
}

conn, err := grpc.NewClient(
Expand Down Expand Up @@ -331,9 +331,9 @@ func runWithRetry(backendEngines []types.Backend) func(ctx context.Context, c *c
retryCount := c.Int("connect-retry-count")
retryDelay := c.Duration("connect-retry-delay")
var err error
for i := 0; i < retryCount; i++ {
for range retryCount {
if err = run(ctx, c, backendEngines); status.Code(err) == codes.Unavailable {
log.Warn().Err(err).Msg(fmt.Sprintf("cannot connect to server, retrying in %v", retryDelay))
log.Warn().Err(err).Msg(fmt.Sprintf("cannot connect to %s, retrying in %v", c.String("server"), retryDelay))
time.Sleep(retryDelay)
} else {
break
Expand Down