Support matrix environ badges only with no key-values#5578
Conversation
|
Are empty values somehow important / do they have an effect on sth? |
|
Kinda, in this case the plugin config is set dynamically from the matrix env. That means one pipeline is using |
|
add an cursive empty ? |
|
Yes we can do that if we prefer it that way. |
|
yes please - as droping it would hide information that the user could need to know for fully understanding what's happening |
|
Do we want to have the string translated? Or should we use something like null without translations? Translating this string could make it very long. |
|
We could also avoid the "white" part and make the gray round on the right in case its empty. Would not use an english string in there. If you want a string we could use "-" as well, however that could always lead to someone thinking that's the actual value. |
|
the idea to make a simple lable without the second part is a better idea no need for i18 problems |
6543
left a comment
There was a problem hiding this comment.
lgtm based on screenshot
and code looks rightish
Fixes:
After that change: