Skip to content

Support matrix environ badges only with no key-values#5578

Merged
6543 merged 2 commits into
mainfrom
matrix-badges
Oct 1, 2025
Merged

Support matrix environ badges only with no key-values#5578
6543 merged 2 commits into
mainfrom
matrix-badges

Conversation

@xoxys

@xoxys xoxys commented Sep 30, 2025

Copy link
Copy Markdown
Member

Fixes:

grafik

After that change:

image

@xoxys xoxys added bug Something isn't working ui frontend related labels Sep 30, 2025
@xoxys xoxys requested a review from a team September 30, 2025 13:16
@anbraten

Copy link
Copy Markdown
Member

Are empty values somehow important / do they have an effect on sth?

@xoxys

xoxys commented Sep 30, 2025

Copy link
Copy Markdown
Member Author

Kinda, in this case the plugin config is set dynamically from the matrix env. That means one pipeline is using tag_suffix: "insecure" and another one tag_suffix: "". However, if we want to display empty values, how should they look like?

@6543

6543 commented Sep 30, 2025

Copy link
Copy Markdown
Member

add an cursive empty ?

@xoxys

xoxys commented Sep 30, 2025

Copy link
Copy Markdown
Member Author

Yes we can do that if we prefer it that way.

@6543

6543 commented Sep 30, 2025

Copy link
Copy Markdown
Member

yes please - as droping it would hide information that the user could need to know for fully understanding what's happening

@xoxys

xoxys commented Sep 30, 2025

Copy link
Copy Markdown
Member Author

Do we want to have the string translated? Or should we use something like null without translations? Translating this string could make it very long.

@anbraten

anbraten commented Sep 30, 2025

Copy link
Copy Markdown
Member

We could also avoid the "white" part and make the gray round on the right in case its empty. Would not use an english string in there. If you want a string we could use "-" as well, however that could always lead to someone thinking that's the actual value.

@6543

6543 commented Sep 30, 2025

Copy link
Copy Markdown
Member

the idea to make a simple lable without the second part is a better idea no need for i18 problems

@6543 6543 added the wip label Oct 1, 2025
@6543 6543 marked this pull request as draft October 1, 2025 15:22
@xoxys xoxys removed the wip label Oct 1, 2025
@xoxys xoxys marked this pull request as ready for review October 1, 2025 18:21
@xoxys xoxys requested review from a team and removed request for a team October 1, 2025 18:22
@6543 6543 changed the title Show matrix environ badges only if key has value Support matrix environ badges only with no key-values Oct 1, 2025

@6543 6543 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm based on screenshot

and code looks rightish

@6543 6543 merged commit 601fe4a into main Oct 1, 2025
7 checks passed
@6543 6543 deleted the matrix-badges branch October 1, 2025 19:11
This was referenced Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ui frontend related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants