Enable completion support for cli#5552
Conversation
|
Surge PR preview deployment succeeded. View it at https://woodpecker-ci-woodpecker-pr-5552.surge.sh |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5552 +/- ##
==========================================
+ Coverage 19.52% 19.54% +0.01%
==========================================
Files 416 417 +1
Lines 39567 39581 +14
==========================================
+ Hits 7726 7736 +10
- Misses 31144 31147 +3
- Partials 697 698 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks! Just for understanding, why don't we use the defaults and hide it? PS: Added Norwegian to our Weblate as you requested. |
Thank you. My thinking was that it's better if it appears in the help menu if someone downloads the binary and wants to add completion for their shell. The completion help also includes specific instructions for each shell. If you prefer that it's hidden I can update the PR. I'm planning to do a update to the nix package as well to use the completion once it's in a release. |
This PR enables the built in urfave autocomplete generator.
ref https://cli.urfave.org/v3/examples/completions/customizations/
I'm using the customization to ensure it's included in the help text.
Also skipping the setup check to ensure you can generate completion at install
time.