Skip to content

Allow to get secrets from file#5509

Merged
qwerty287 merged 2 commits into
woodpecker-ci:mainfrom
qwerty287:sec-file
Sep 14, 2025
Merged

Allow to get secrets from file#5509
qwerty287 merged 2 commits into
woodpecker-ci:mainfrom
qwerty287:sec-file

Conversation

@qwerty287

@qwerty287 qwerty287 commented Sep 14, 2025

Copy link
Copy Markdown
Contributor

closes #5417

@qwerty287 qwerty287 requested a review from a team September 14, 2025 07:57
@qwerty287 qwerty287 added enhancement improve existing features cli labels Sep 14, 2025
@woodpecker-bot

woodpecker-bot commented Sep 14, 2025

Copy link
Copy Markdown
Contributor

Surge PR preview deployment succeeded. View it at https://woodpecker-ci-woodpecker-pr-5509.surge.sh

@codecov

codecov Bot commented Sep 14, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.40%. Comparing base (73d2517) to head (0393482).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cli/exec/exec.go 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5509      +/-   ##
==========================================
- Coverage   26.41%   26.40%   -0.02%     
==========================================
  Files         404      404              
  Lines       28842    28858      +16     
==========================================
  Hits         7620     7620              
- Misses      20527    20543      +16     
  Partials      695      695              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@qwerty287 qwerty287 merged commit 47a0005 into woodpecker-ci:main Sep 14, 2025
7 of 9 checks passed
@qwerty287 qwerty287 deleted the sec-file branch September 14, 2025 10:26
@woodpecker-bot woodpecker-bot mentioned this pull request Sep 14, 2025
1 task
Comment thread cli/exec/flags.go
},
&cli.StringFlag{
Sources: cli.EnvVars("WOODPECKER_SECRETS_FILE"),
Name: "secrets",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it supposed to be secrets-file ? @qwerty287

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it is. This can't work right now... You want to open a PR to fix it?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I can fix it

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gjuoun gjuoun mentioned this pull request Jan 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli enhancement improve existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Secrets to woodpecker-cli exec command via file

4 participants