Skip to content

refactor: use slices.Contains to simplify#5468

Merged
qwerty287 merged 1 commit into
woodpecker-ci:mainfrom
zhedazijingang:main
Aug 28, 2025
Merged

refactor: use slices.Contains to simplify#5468
qwerty287 merged 1 commit into
woodpecker-ci:mainfrom
zhedazijingang:main

Conversation

@zhedazijingang

Copy link
Copy Markdown
Contributor

There is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.

Signed-off-by: zhedazijingang <unwrap_or_else@outlook.com>
@qwerty287 qwerty287 added the refactor delete or replace old code label Aug 28, 2025
@codecov

codecov Bot commented Aug 28, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.44%. Comparing base (7886f4a) to head (b591306).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
server/model/task.go 0.00% 2 Missing ⚠️
server/pipeline/cancel.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5468   +/-   ##
=======================================
  Coverage   26.43%   26.44%           
=======================================
  Files         403      403           
  Lines       28805    28789   -16     
=======================================
- Hits         7616     7612    -4     
+ Misses      20494    20482   -12     
  Partials      695      695           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@qwerty287 qwerty287 merged commit 2349ee1 into woodpecker-ci:main Aug 28, 2025
9 checks passed
@woodpecker-bot woodpecker-bot mentioned this pull request Aug 27, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor delete or replace old code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants