Skip to content

Add pipeline author and avatar env vars#5227

Merged
xoxys merged 7 commits into
woodpecker-ci:mainfrom
qwerty287:pl-avatar
Jun 27, 2025
Merged

Add pipeline author and avatar env vars#5227
xoxys merged 7 commits into
woodpecker-ci:mainfrom
qwerty287:pl-avatar

Conversation

@qwerty287

Copy link
Copy Markdown
Contributor

@qwerty287 qwerty287 requested a review from a team May 31, 2025 07:06
@qwerty287 qwerty287 added the enhancement improve existing features label May 31, 2025
@woodpecker-bot

Copy link
Copy Markdown
Contributor

Deploying preview to https://woodpecker-ci-woodpecker-pr-5227.surge.sh

@codecov

codecov Bot commented May 31, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 26.35%. Comparing base (a02de81) to head (1d1ff31).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pipeline/frontend/metadata/environment.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5227      +/-   ##
==========================================
- Coverage   26.36%   26.35%   -0.02%     
==========================================
  Files         401      401              
  Lines       28537    28543       +6     
==========================================
- Hits         7525     7522       -3     
- Misses      20323    20332       +9     
  Partials      689      689              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pat-s pat-s left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What use case does the avatar have?

While it's surely not harming, it extends the list and makes it bigger without a real use case (?).

@qwerty287

Copy link
Copy Markdown
Contributor Author

@6543 suggested it in #4626

anbraten
anbraten previously approved these changes May 31, 2025
@anbraten anbraten dismissed their stale review May 31, 2025 13:37

unsure about the necessity

@qwerty287

Copy link
Copy Markdown
Contributor Author

Can we get a decision here? I don't care tbh. @6543 what do you say? You originally suggested this.

@xoxys

xoxys commented Jun 15, 2025

Copy link
Copy Markdown
Member

Also not sure about the use case but its just an env var and it doesnt increase the code complexity so why not.

@anbraten anbraten left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've searched for it and saw it being used by notification plugins to show the author and their avatar

Comment thread pipeline/frontend/metadata/types.go
@qwerty287 qwerty287 requested a review from anbraten June 17, 2025 11:21
@qwerty287 qwerty287 requested review from pat-s and xoxys June 17, 2025 16:46
@xoxys xoxys merged commit 2184407 into woodpecker-ci:main Jun 27, 2025
6 of 7 checks passed
@woodpecker-bot woodpecker-bot mentioned this pull request Jun 27, 2025
1 task
@qwerty287 qwerty287 deleted the pl-avatar branch June 28, 2025 06:07
@nmapx

nmapx commented Jul 31, 2025

Copy link
Copy Markdown

Have you noticed it overrides the commit author? I don't know if that's how it supposed to work, looks weird.
If you trigger the pipeline manually on a commit that you did not pushed it's gonna say that "prev commit author" is the person that actually pushed the commit woodpecker is actually processing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement improve existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants