Add milestone to metadata

[6543]

closes #3285

---

Sponsored by Kithara Software GmbH

[woodpecker-bot]

Surge PR preview deployment was removed

[codecov]

Codecov Report

❌ Patch coverage is 65.11628% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.44%. Comparing base (2349ee1) to head (d26c092).
⚠️ Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
server/forge/gitlab/gitlab.go	20.00%	7 Missing and 1 partial ⚠️
server/forge/gitlab/convert.go	50.00%	4 Missing ⚠️
pipeline/frontend/metadata/environment.go	0.00%	1 Missing ⚠️
server/forge/forgejo/helper.go	87.50%	1 Missing ⚠️
server/forge/gitea/helper.go	87.50%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5174      +/-   ##
==========================================
+ Coverage   26.42%   26.44%   +0.02%     
==========================================
  Files         403      403              
  Lines       28789    28811      +22     
==========================================
+ Hits         7607     7620      +13     
- Misses      20487    20496       +9     
  Partials      695      695              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[6543]

[6543]

done

[qwerty287]

I think it would be nice to get #4626 in first because it simplifies the structure of the pipeline model a lot.

[6543]

I think it would be nice to get #4626 in first because it simplifies the structure of the pipeline model a lot.

I personally thing that this pr should be merged and I can also resolve the conflicts in #4626 if you want ... because it does not look like the dessision of releaseing a new majour version is not started at all ... else of course it would make sense to wait ?

[xoxys]

Well... please dont rush on this one as well just because you are interested in this particular one.

[6543]

fair point ;) - as per disclaimer that one is for my dayjob and I can atm run this patch by compiling my version

[6543]

one thing to clarify would be if the milestone is ok to be exposted as env var at some point or not.
in that case it would be future prove for me to do an API call instead etc...

[xoxys]

Isnt this PR already exposing CI_COMMIT_PULL_REQUEST_MILESTONE as env var or what do you mean?

[6543]

It's all fine with this PR... yes, it does exactly as mentioned.

The workaround if this won't land is to let tools who need it query the milestone on their own, which makes it quite complicated... that's all what I meant.

[xoxys]

Got it. Fine for me to expose this env var in general.

[qwerty287]

I'd still prefer getting #4626 merged first, but as this will likely take more time it's probably better to start here.

Just the usual question: What about bitbucket? Does it support milestones?

For datacenter cc @langecode

[6543]

sadly i dont think so as bb forwards all tiket/issue like handling into a other product atlasian jira? witch is independent from bb managed and you just track things there and ref only in bb ...

... correct me if i'm wrong - dont do dev work with bb myselfe

[langecode]

No, I do not believe there’s is anything like milestones in BB. BB is purely git, I believe milestones are more like release management and issues/pull-requests? I think the vendor of BB would point to Jira.

…

Message ID: ***@***.***>