Refactor server/.../step_builder into pipeline/.../builder#3967
Merged
Conversation
anbraten
changed the title
depends_on in cli & move stepbuilder
6543
reviewed
Jul 24, 2024
Contributor
|
Surge PR preview deployment was removed |
anbraten
changed the title
depends_on in cli & move stepbuilder
6543
reviewed
Apr 19, 2026
6543
reviewed
Apr 19, 2026
6543
reviewed
Apr 19, 2026
This was referenced Apr 20, 2026
6543
approved these changes
May 1, 2026
6543
reviewed
May 13, 2026
This reverts commit d4a888e.
6543
approved these changes
May 13, 2026
Member
6543
left a comment
6543
left a comment
There was a problem hiding this comment.
i re-reviewed as if i did not touch it at all ... well i only found one thing and that was a false-negative ...
6543
added a commit
that referenced
this pull request
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract the
step_builderfrom the server to the pipeline package.This cleans the interfaces / structure and will allow us to re-use it in the cli to correctly support pipeline execution (things like
depends_onsupport).