Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.2 support. #292

Merged
merged 6 commits into from
Aug 17, 2023
Merged

Add PHP 8.2 support. #292

merged 6 commits into from
Aug 17, 2023

Conversation

mikkamp
Copy link
Contributor

@mikkamp mikkamp commented Aug 16, 2023

Changes proposed in this Pull Request:

This PR fixes some deprecation messages when run on a site with PHP 8.2. This was mostly resolved by declaring the class properties for all the settings.

In addition to that the dismissed_info_banner property was removed as it was no longer present and had been removed in PR #260

I've also modified the phpunit workflow to test with newer PHP versions including PHP 8.2.

Note
The workflow change will conflict with PR #290 when it's merged, but this should be relatively straightforward to merge.

Closes #291

Detailed test instructions:

  1. Test extension on a site with PHP 8.2 and WP_DEBUG enabled
  2. Setup some basic settings
  3. Purchase a product (in an incognito window)
  4. Confirm that tracking events are being recorded
  5. Ensure there aren't any warnings / deprecation messages showing up at any stage
  6. Check the automated PR tests and confirm they ran for PHP 8.2 without errors

Changelog entry

  • Compat - Add PHP 8.2 support.

@mikkamp mikkamp self-assigned this Aug 16, 2023
@github-actions github-actions bot added changelog: fix Took care of something that wasn't working. type: bug The issue/PR is a confirmed bug. labels Aug 16, 2023
@mikkamp mikkamp requested a review from a team August 16, 2023 14:04
Copy link
Contributor

@jorgemd24 jorgemd24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mikkamp for working on this. LGTM 👍

✅ I've compared the PHP Unit tests using both PHP 8.0 and PHP 8.2, and the deprecation notices have been resolved.

✅ Additionally, I've verified that the tracking events are being properly recorded.

@mikkamp mikkamp merged commit 25b252e into trunk Aug 17, 2023
5 checks passed
@mikkamp mikkamp deleted the fix/291/php8-2-compatibility branch August 17, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: fix Took care of something that wasn't working. type: bug The issue/PR is a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check for compatibility with PHP 8.2
2 participants