Skip to content

Conversation

@daigo75
Copy link

@daigo75 daigo75 commented Mar 4, 2021

All Submissions:

  • Does your code follow the Extendables standards? I think so, but can't say, the link to the standards can't be reached.
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changes proposed in this Pull Request:

Integration with the Aelia Currency Switcher, for multi-currency support. We proposed the same integration a few months ago to Sau/Cal, but it hasn't been added to the Amazon Pay plugin, yet.

How to test the changes in this Pull Request:

  1. Install and configure the Aelia Currency Switcher (free copy available on request), enabling multiple currencies.
  2. Go to WooCommerce > Settings > Payments > Amazon Pay.
  3. Verify that the integration is active (see https://prnt.sc/10d2jg0).
  4. Enable Amazon Pay for some currencies in the gateway settings.
  5. Enable Amazon Pay for the same currencies at WooCommerce > Currency Switcher > Payment Gateways (see https://prnt.sc/10d2izo).
  6. Place an order in the enabled currencies, paying with Amazon. and verify that it's processed correctly.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changelog entry

Added integration with the Aelia Currency Switcher, for multi-currency support.

Diego added 2 commits March 1, 2021 14:28
* Put the Aelia Currency Switcher at the top of the list, to ensure that it's detected even when WCML is installed.
@kalessil kalessil closed this in b553602 May 4, 2021
@daigo75
Copy link
Author

daigo75 commented May 4, 2021

@kalessil I received a notification that this PR has been closed, but it doesn't look like it was merged. Was it closed by mistake?

Note: the PR b553602, referenced in the closure note, mentions this request, but it's not related to it. That PR refers to WCML, which is a different plugin, and not related to the Aelia Currency Switcher, for which I submitted my PR.

@daigo75
Copy link
Author

daigo75 commented May 12, 2021

@kalessil @msaggiorato Just a ping to remind that this PR has been closed without a merge. The PR that claims to have closed it is unrelated to the changes in this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant