This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Revert "Remove unused Add to Cart product element (#11948)" #12033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b8332dd.
Aljullu
added
type: bug
Add types for `useAddToCartFormContext`Add types for `useAddToCartFormContext` 🚀 This comment was generated by the automations bot based on a
|
Add types for `useAddToCartFormContext`Add types for `useAddToCartFormContext` 🚀 This comment was generated by the automations bot based on a
|
Add types for `useAddToCartFormContext`Add types for `useAddToCartFormContext` 🚀 This comment was generated by the automations bot based on a
|
woocommercebot
requested review from
a team and
albarin
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
assets/js/atomic/blocks/product-elements/add-to-cart/product-types/variable/variation-attributes/attribute-select-control.tsx
|
|
Size Change: +82.5 kB (+5%) 🔍 Total Size: 1.61 MB
ℹ️ View Unchanged
|
kmanijak
approved these changes
Dec 4, 2023
Aljullu
added a commit
that referenced
this pull request
Dec 4, 2023
Aljullu
added a commit
that referenced
this pull request
Dec 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts PR #11948.
What
Fixes #12032.
Why
For some reason, that PR was causing an incompatibility between the All Products block and the Mini-Cart block. I didn't investigate it further, but I propose to revert the PR and re-open woocommerce/woocommerce#44503 so this doesn't block the 11.7.0 release.
Testing Instructions
Note: the issue only happens when building with
npm run build. It's not reproducible withnpm run start.Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog