This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Update Feedback link on Cart and Checkout blocks #12006
Merged
wavvves
merged 3 commits into
trunk
from
update/change_feedback_link_on_cart_and_checkout
Dec 1, 2023
Merged
Update Feedback link on Cart and Checkout blocks #12006
wavvves
merged 3 commits into
trunk
from
update/change_feedback_link_on_cart_and_checkout
Dec 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wavvves
added
skip-changelog
PRs that you don't want to appear in the changelog.
type: task
The issue is an internally driven task (e.g. from another A8c team).
labels
Dec 1, 2023
wavvves
removed
the
type: task
The issue is an internally driven task (e.g. from another A8c team).
label
Dec 1, 2023
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: -167 B (0%) Total Size: 1.53 MB
ℹ️ View Unchanged
|
nielslange
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, @wavvves. The change works as expected. Let's ⛴️ this change. 🙌
wavvves
added a commit
that referenced
this pull request
Dec 1, 2023
* Update feedback link * Remove default url link, and make the param required
wavvves
added a commit
that referenced
this pull request
Dec 5, 2023
* Empty commit for release pull request * Update feedback link (#11999) * Update Feedback link on Cart and Checkout blocks (#12006) * Update feedback link * Remove default url link, and make the param required * Updated readme.txt Updated versions Added testing steps * Remove page view tracking in favor of jetpack (#12010) * import checkbox from single place (#12015) * Revert "import checkbox from single place (#12015)" This reverts commit d952f8e. * Updated testing zip link --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: Paulo Arromba <[email protected]> Co-authored-by: Seghir Nadir <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Follow up PR to complete #11999
Fixes #11990
Why
The
Give us your feedback
link currently points to the WooCommerce Blocks repo instead of WooCommerce repo discussions.Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]
label or a[skip-changelog]
label.Conditional:
[skip-changelog]
label is not present).Changelog