This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Update notice for default cart and checkout #11861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielslange
added
type: enhancement
woocommercebot
requested review from
a team and
senadir
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: -94 B (0%) Total Size: 1.61 MB
ℹ️ View Unchanged
|
senadir
approved these changes
Nov 21, 2023
nielslange
force-pushed
the
update/11777-update-default-cart-and-checkout-notice
branch
from
257c1c4
to
089551a
Compare
Thanks for your review, @senadir, and for pointing out the i18n issue. I've addressed it, as suggested by you. |
nielslange
deleted the
update/11777-update-default-cart-and-checkout-notice
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #11777
Why
In p1699988291133359/1699592175.220079-slack-C02UBB1EPEF, @elizaan36 asked to replace the button in the component with an inline link and to display an info notice instead of a warning notice.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
Cart block
Checkout block
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog