This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Pass order ID to woocommerce_before_thankyou hook #11852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit resolves a compatibility issue where the woocommerce_before_thankyou hook was receiving an order object instead of an order ID. By passing the order ID directly using $order->get_id(), this change ensures backward compatibility with plugins that expect an integer order ID.
|
The release ZIP for this PR is accessible via: TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the |
|
Size Change: 0 B Total Size: 1.59 MB ℹ️ View Unchanged
|
|
Closing in favor of #11862 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #11851
Compatibility issue with
woocommerce_before_thankyouhookWhy
This commit resolves a compatibility issue where the
woocommerce_before_thankyouhook was receiving an order object instead of an order ID. By passing the order ID directly using$order->get_id(), this change ensures backward compatibility with plugins that expect an integer order ID, since that is what WooCommerce has always passed.Testing Instructions
Screenshots or screencast
N/A
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog